feat!: rename rawprogram-ufs.xml to rawprogram-4k.xml#330
Closed
Agathe Porte (gagath) wants to merge 1 commit into
Closed
feat!: rename rawprogram-ufs.xml to rawprogram-4k.xml#330Agathe Porte (gagath) wants to merge 1 commit into
Agathe Porte (gagath) wants to merge 1 commit into
Conversation
In Github issue qualcomm-linux#264 is discussed [1] how to flash the Glymur NVME using a rawprogram-nvme.xml file. Since our Glymur boot firmware seems to support 4k sector sizes [2], rename the rawprogram-ufs.xml to rawprogram-4k.xml as it can be used to flash both UFS and NVME devices. [1] qualcomm-linux#264 (comment) [2] qualcomm-linux/qcom-distro-images#37 Closes: qualcomm-linux#273 Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
Contributor
|
Did you test this on NVMe? In mkosi-qcom, the nvme flashing file uses 512 bytes sectors https://github.com/qualcomm/mkosi-qcom/blob/main/rawprogram-nvme.xml |
Contributor
Author
|
I thought it was already validated for Glymur but after reading https://github.com/qualcomm-linux/qcom-distro-images/pull/37#top in more details it was only validated on Hamoa. I will test this on Glymur and put the PR back in a ready state when validated. I think also that maybe we should keep the |
Test jobs for commit 58d05c2 |
Contributor
Author
|
I am at peace with the ufs/sdcard naming now; closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Github issue #264 is discussed [1] how to flash the Glymur NVME using a rawprogram-nvme.xml file. Since our Glymur boot firmware seems to support 4k sector sizes [2], rename the rawprogram-ufs.xml to rawprogram-4k.xml as it can be used to flash both UFS and NVME devices.
[1] #264 (comment)
[2] https://github.com/qualcomm-linux/qcom-distro-images/pull/37
Closes: #273